next »

[Derroylo]

First i would like to say it is really a nice tool and looks way better as AORC Did you made all icons etc yourself? If yes with which tool?

Got a site not found error. It happened after i got invited to a private group(new window opened) and when i clicked on a Link that was posted in that group(Bot is Budabot and it happened independent on which link i clicked) the popup opened correctly and content was correct. After the popup was opened i got a site not found error in the privategroup window.

Could the privategroup also be added to the Channellist? Once you have closed the window you can´t reopen the window

Keep up the good work

[POD13]

As a follow up to the inability to send tell messages, it appears to work fine to anyone who's also connected to only the chat server (i.e. Helpbot, Guild bots, Confabulator users, etc), but not to people in the game.  If they are offline, they do get a message that you sent them an offline message, but they don't get what the message was.  So... there must be something I'm doing that the game server doesn't like in tells, but I haven't figured out what the problem is yet.  Everything else seems to work fine.

The icons were originally from iStockPhoto and I added a 3-D effect in Photoshop.

Once you close the private group window, you also disconnect from that private group so keeping the group in the channel list wouldn't make sense.  You would have to get reinvited anyway.  I could give you a warning message if you try to close a private group window without disconnecting first, i guess.

The random 404 errors are going to be the death of this tool unless I figure out a reliable workaround.

[Derroylo]

Once you close the private group window, you also disconnect from that private group so keeping the group in the channel list wouldn't make sense.  You would have to get reinvited anyway.  I could give you a warning message if you try to close a private group window without disconnecting first, i guess.

The random 404 errors are going to be the death of this tool unless I figure out a reliable workaround.

Ah. Yeah a little error message would be good at that place

Well this one isn´t random it was always reproducable. Will try to see if i can find the problem what is this causing after i wrote my examen on Monday

[POD13]

-- The application now sends tells. Turns out the way I was building the Blob part of the message was leaving it off when sent over the wire. I changed it to a single zero byte Blob and its fine with that.
-- You'll get a prompt if you try to close a private group window without leaving it first.
-- Tells you send are now formatted more like they are in-game.
-- I changed the default colors to be more like the default game colors. (I think) If you want you can load these colors from the settings panel Reset to Default button, but this will blow away any custom settings you've made.

I can't replicate the 404 problem.  I've tried.  I'm wondering for those getting a 404 are you using the zip install or the web install.  Maybe it has to do with web page caching and file permissions or something.

POD13

[Derroylo]

I have used the zip install and as promised i will take a look at the program with VS Debugger when my exam is written today but can´t promise much as i am still a C# Noob

[Mossi]

-- The application now sends tells. Turns out the way I was building the Blob part of the message was leaving it off when sent over the wire. I changed it to a single zero byte Blob and its fine with that.

Thank you for the fix. Did you also upload a new version of the library sources?

[Derroylo]

Some more stuff i would like to see getting fixed/changed:
- You can´t see if a player is offline or not when he is on others category
- If you send an tell to an offline player, you should get a little note that the player is off
- The program should save muted channels and set them to this value again when you restart it

Regarding the Site not found error i am getting when i click on an link. For example i am doing !online, the window gets opened(something with the newline is incorrect there still but that is another point) and when i am clicking there on a chatcommand(to see the alts of an person) i get the site not found error. This one could be fixed with(File htmlpopup.cs):

        void browser_Navigating(object sender, WebBrowserNavigatingEventArgs e)
        {
            if(e.Url.OriginalString == "about:blank")
                e.Cancel = false;
            else
                e.Cancel = true;
            System.Diagnostics.Debug.Print("navigating: " + e.Url.OriginalString);
        }

He is trying to navigate after you have clicked on the link which causes that side not found error. With the code above this case is handled correct now and is working as it should be.

Will look after the newline problem and the other site not found thingy.

[Derroylo]

Regarding the newline problem(all output of !Online is in one line) i am a bit clueless why that happens. Bot is using only \n for a newline, as sideinfo.

After a bit of debugging i came across this function which i think causes the problem
AddMessageElement(HtmlDocument document, Color forecolor, string content)(in ChatWindowBasic.cs)

The replace function doesn´t seems to work for an me not understandable reason.
Tried to add the following code:
            string tmp = content.Replace(@"\n", @"
");
            message.InnerHtml = tmp;

which should replace all \n in the text with
 but afterwards i see still not a single \n replaced by this function. Do i miss something?

[Vhab]

yeah, you missed the @, adding that prevents the \n from being an actually new line and it's a string with '\n' now

[Derroylo]

Ah thx

In AddMessageElement(in ChatWindowBasic.cs)
replace the current line with:

Code:

message.InnerHtml = content.Replace(Environment.NewLine, @"<br>").Replace("\n", @"<br>");

and the content is shown correct.

*Goes over to the next bug*

[Derroylo]

The webcontrol has a property "AllowNavigation" set it to false and you shouldn´t get the site not found error anymore. The Browser trys to navigate as soon you click on a link which is causing this errors.


One more thing i came across. Something is not correct handled within the initialisation of the program. When you go over the Buttons on the Top(Like connect, Open settings and so on) their label isn´t showing when you move with the mouse over it. Also the Buttons doesn´t work on the first click(no button click event thrown), after you clicked once somewhere in the toolbar it works.

[POD13]

Wow! Glad to see someone is working on this tool!    Nice work Derroylo.

-- Implemented Derroylo's fix for the 404 errors.  I wasn't getting them before this fix and am not getting them now.  Hopefully, this makes it better for everyone.  I tried setting AllowNavigation to false, but it broke other stuff.

-- Added the fix for the new lines.  Thanks Derroylo and Vhab.

-- You'll get a system message if you send an offline tell to someone.  Thanks Vhab for the mmdb tool.

-- The debug window doesn't crash if you close it. Thanks Ebag333. There's now an option for showing the debug window in the settings. 

> Oddly enough if you turn off displaying the debug window, then it fixes the problem of the buttons not firing the first time.  Something with the debug window opening and hiding itself is swallowing the first button event.  This isn't something I plan on investigating further.

> The server doesn't tell you the status of non-buddies.  You could do the same thing that bots do.  Add them to your buddy list, get the status and then remove them.  I suppose I could do all this for you...

> Saving muted channels is part of the unfinished effort of saving windows and their locations since open channels are per-window not global.

[Vhab]

At first glance of the latest version
- Linebreaks are fixed \o/
- Due to the fact we put everything into a browser control, multiple spaces after each other are not displayed. this does work in AO, maybe search out multiple spaces and replace em with &nbsp; (However, if they end up being included inside clickable links too, maybe remove them before sending the command)
- The 404 bug is still 100% reproducable for me atm. I start up, /tell beastnet version. click the window. new window opens correctly, original window goes 404. I really have reason to believe it depends on the way the window is defined. When I do /tell helpbot help, I don't get the 404.
- Clan Leader chat is marked in a section called '4', I'll assume this is just the channel type ID and you didn't implement a name for it.
- The output in the window of '/tell beastnet whois vhab' went a bit screwy. I think it's due to some characters inside the auno link inside the window.
- It doesn't support special characters for me atm.
Intended: Beastnet: VhaBot 0.6.4 Beta »» More Information
Shown: Beastnet: VhaBot 0.6.4 Beta More Information

Will fire it up in debug when I get the time.

[Ebag333]

Couple of issues I've found.  Sorry if any of these are already known. 

• Very long messages seem to get cut off in info windows.  If you're on RK2, you can do a couple different things to test it.
  /tell Cafbot !guide Quest - Ergo Story
  /tell Caftrade !shop
  The guide got cut off at around 3863 characters, !shop got cut off at around 4064 (the guide has more breaks in it, that might be the difference).
  
  
• No copy/paste support out of the chat window.  CTRL-C doesn't work, and I really miss the right click context popup window. (Debug window works just fine)   
  
  
• Font size/type/etc doesn't change the timestamp, channel, or player name.  I would prefer for those to be a different setting (so I can change them to be different than the chat text).  But having huge channel/player names and tiny text is quite distracting. 
  
  Interestingly enough, tells to a player have the To player: part as the modified size, tells FROM the player have the [Player]: part as the default size.  Also, should look at either always having the player name linkable, or never having it (slightly distracting when players name changes color every other line).  Maybe an option?
  
  
• The following link inside an info window doesn't work.
  To replicate:
  /tell cafbot !timer add 1 test
  /tell cafbot !timer list
  Once you get the list try and click Delete.

Code:

<font color="#9CD6DE">Timers  <a href="charref://1/11691404471992/</font><font color=#FFFFFF>test <a href='chatcmd:///tell Cafbot !timer del Ebagmp once test'></font><font color=#9CD6DE>Delete</a>
</font><font color=#FFFFFF>Owner: </font><font color=#9CD6DE>Ebagmp
</font><font color=#FFFFFF>Timer Length: </font><font color=#9CD6DE>once
</font><font color=#FFFFFF>Time Remaining: </font><font color=#FF0000>0 hours, 9 minutes, and 53 seconds

">Click to view list</a>

• The following link isn't clickable (posted directly to org chat).

Code:

<a href="charref://1/11691407167063/</font><font color=#FFFFFF>::: Click below to view shops :::.</font><font color=#9CD6DE>
</font><font color=#9CD6DE><a href='chatcmd:///tell caftrade !shop '>View All Shops (By Shop Owner)</a>
</font><font color=#9CD6DE><a href='chatcmd:///tell caftrade !shopsearch '>View All Shops (By Category)</a>
</font><font color=#9CD6DE><a href='chatcmd:///tell caftrade !shop help '>Create your own shop</a>

</font><font color=#FFFFFF>::: Other shops hosted by CCI :::.</font><font color=#9CD6DE>
</font><font color=#9CD6DE><a href='chatcmd:///tell sabaworkshop !shop '>Calloshop's Arul Saba Workshop</a>"><font color="#9CD6DE">:::<font color="#FF0000">:::<font color="#9CD6DE">::: Shops! Click Here Now! <font color="#9CD6DE">:::<font color="#FF0000">:::<font color="#9CD6DE">:::</a>

• Settings don't keep when you close and re-open application.  Such as what channels are muted, what windows are open, showing buddylist, etc.  Not a big deal for me, but since I mute all the default channels (shopping, towers, etc) every time I open the app, it's a few extra steps.
  
  
• Your links in the about window are clickable, but do nothing. (in UserCustomizations...I think you're missing a space there too.)  HIGHLY important.
  
  
• Support for ingame images - More of a feature request than a bug, but would it be possible to support the ingame images?  IE: links such as <img src=tdb://id:GFX_GUI_FRIENDLIST_SPLITTER> or <img src=rdb://16300>
• Store last few messages - Could we get functionality as is ingame to hit shift-up/down and scroll through out last sent messages?  I use this a lot.
  
  
• Dropdown next to input box only shows who you're sending to currently.  Possible to have it list all the channels you are subscribing to in that window?
  
  
• Chat windows opening in a new window.  Possible to get it tabbed by default? (Ala IRC)

Hope that doesn't overwhelm ya.   

If you don't have access to any of those commands for whatever reason, or just want to chat with me ingame, shoot me a tell on Ebagmp. (RK2 of course)

[BETEP]

I know that author has abondoned this project, but I am sure - sombody can help to solve at least this problem:

Couple of issues I've found.  Sorry if any of these are already known. 

• Very long messages seem to get cut off in info windows.  If you're on RK2, you can do a couple different things to test it.
  /tell Cafbot !guide Quest - Ergo Story
  /tell Caftrade !shop
  The guide got cut off at around 3863 characters, !shop got cut off at around 4064 (the guide has more breaks in it, that might be the difference).
  

after some digging, i found roots of that problem:

in ChatWindowBasic.cs,

Code:

        private void AddMessageElement(HtmlDocument document, Color forecolor, string content)
        {
            if (content.ToLower().StartsWith("</font>"))
                content = content.Substring(7);

            HtmlElement message = document.CreateElement("span");
            message.Style = HtmlPopup.GetStyleString(Settings.Default.MessageColorBackground, forecolor, Settings.Default.MessageFontDefault);
            message.SetAttribute("class", "message");
            message.InnerHtml = content.Replace(Environment.NewLine, @"<br />").Replace("\n", @"<br />");
           
            document.Body.AppendChild(message);
        }

InnerHtml has limit in 4096 bytes. Does anybody know if this limit can be changed to somethhin big (like 100k or even 1m)?
Or can this be implemented without using InnerHtml?

PS: I know - necroposting is bad, but...